Does setvars need to run before make?

Open bdmoore1 opened this issue 3 years ago • 1 comments

https://github.com/oneapi-src/oneAPI-samples/blob/d9c80018a09b14f9a04ab06dab0472fab15f1c9d/DirectProgramming/C%2B%2B/CombinationalLogic/MandelbrotOMP/README.md?plain=1#L64

The instructions do not mention the need to source setvars before building the program. Should I add them, or does Mandelbrot OMP not need setvars? @tomlenth @akertesz @ethanhirsch

Feb 09 '22 00:02 bdmoore1

I believe our sample readme's may not always be consistent around mention of setvars. If the user has already run it, we obviously don't want them re-running it. So, in many samples it's implied that it's already run. the DPCPP flavor of Mandelbrot includes the optional setvars content that we probably should standardize around for the samples, including this OMP version.

Feb 09 '22 01:02 tomlenth