oneAPI-samples icon indicating copy to clipboard operation
oneAPI-samples copied to clipboard

WIP: Make Fortran USM example similar to C++

Open bkmgit opened this issue 2 years ago • 1 comments

Existing Sample Changes

Description

Transform to be similar to C++ USM demonstration code

Fixes Issue# https://github.com/oneapi-src/oneAPI-samples/issues/1657

External Dependencies

none

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Command Line
  • [ ] oneapi-cli
  • [ ] Visual Studio
  • [ ] Eclipse IDE
  • [ ] VSCode
  • [ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Delete this line and everything below if this is not a PR for a new code sample

Delete this line and all above it if this PR is for a new code sample

Adding a New Sample(s)

Description

Please include a description of the sample

Checklist

Administrative

  • [ ] Review sample design with the appropriate Domain Expert: <insert Name Here>
  • [ ] If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager

Code Development

  • [ ] Implement coding guidelines and ensure code quality. see wiki for details
  • [ ] Adhere to readme template
  • [ ] Enforce format via clang-format config file
  • [ ] Adhere to sample.json specification. https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-specification
  • [ ] Ensure/create CI test configurations for sample (ciTests field) https://github.com/oneapi-src/oneAPI-samples/wiki/sample-json-ci-test-object
  • [ ] Run jsonlint on sample.json to verify json syntax. www.jsonlint.com

Security and Legal

  • [ ] OSPDT Approval (see Project Manager for assistance)
  • [ ] Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
  • [ ] Bandit Scans (Python only)
  • [ ] Virus scan

Review

  • [ ] Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
  • [ ] Review readme with Tom Lenth(@tomlenth) and/or Project Manager
  • [ ] Tested using Dev Cloud when applicable

bkmgit avatar May 26 '23 17:05 bkmgit

@bkmgit Can you please resubmit the PR to the development branch? Thanks.

jimmytwei avatar May 30 '23 00:05 jimmytwei