oneAPI-samples icon indicating copy to clipboard operation
oneAPI-samples copied to clipboard

Add files via upload

Open bjodom opened this issue 2 years ago • 6 comments

Existing Sample Changes

Description

These are an update and new addition to the oneAPI samples repo. This is a cleaned up and updated oneMKL example that uses jupyter and demonstrates oneMKL with buffers/accessors, USM, and MPI. While not part of the samples it has been used as an MKL learning path for a year.

Fixes Issue#

External Dependencies

None

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Implement fixes for ONSAM Jiras

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x ] Command Line
  • [ ] oneapi-cli
  • [ ] Visual Studio
  • [ ] Eclipse IDE
  • [ ] VSCode
  • [ ] When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

bjodom avatar Apr 26 '23 21:04 bjodom

Adding @tomlenth @jkinsky We should have a README.md for this? And should this be in the Libraries folder?

jimmytwei avatar Apr 27 '23 21:04 jimmytwei

@jimmytwei yes, it should go into oneMKL and follow a structure that includes the README such as this: sycl-performance-portability-training. This includes supporting files, and naming conventions of both the directory and .py files.

tomlenth avatar Apr 28 '23 00:04 tomlenth

Yes. We should have a readme for all samples. Tom's suggestions for an example works.

ghost avatar Apr 28 '23 20:04 ghost

@jimmytwei and @bjodom - Should this also have a sample.json file?

ghost avatar Apr 28 '23 20:04 ghost

@jkinsky @bjodom Yes, it should if we want it to be picked up by the samples aggregator and the CI for automated testing.

jimmytwei avatar Apr 28 '23 20:04 jimmytwei

@jkinsky @bjodom @tomlenth Looking at this again.

@bjodom:

  1. We'll need a sample.json file for this sample.
  2. We'll need a README.md for this sample too.
  3. Based on @tomlenth comment, I think this should go under Libraries/oneMKL instead of Libraries/

Once those are complete, I'll review it again.

jimmytwei avatar Jun 07 '23 19:06 jimmytwei