level-zero icon indicating copy to clipboard operation
level-zero copied to clipboard

Fix Backwards compatibility in ddi structs for EXP features

Open nrspruit opened this issue 1 year ago • 3 comments

  • Fix incorrect reordering from 1.9.x of the EXP function pointers in ddi tables.

nrspruit avatar Oct 23 '24 16:10 nrspruit

The issue was that the .yaml files were updated such that they indicated that features that were added in 1.9 were "new" in 1.10/1.11, which is not true, they had to be still 1.9 versioned items otherwise the spec scripts cannot order them properly.

nrspruit avatar Oct 23 '24 18:10 nrspruit

The issue was that the .yaml files were updated such that they indicated that features that were added in 1.9 were "new" in 1.10/1.11, which is not true, they had to be still 1.9 versioned items otherwise the spec scripts cannot order them properly.

Got it. I'd recommend fixing yaml files and verifying the generated headers match what you have here. Otherwise this issue is gonna keep coming up and biting us every release

bmyates avatar Oct 23 '24 18:10 bmyates

Spec fix for this issue: https://github.com/oneapi-src/level-zero-spec/pull/314

A bunch of structures and functions were changed to 1.10 or 1.11 when they were originally defined in 1.9

nrspruit avatar Oct 23 '24 18:10 nrspruit

This should be in draft state until the spec changes are merged and released/versioned

Changes have been updated with the latest code in https://github.com/oneapi-src/level-zero-spec/releases/tag/v1.11.1

nrspruit avatar Oct 24 '24 18:10 nrspruit