Non-ascii characters in files

Open SebastianLuzynski opened this issue 3 years ago • 6 comments

There are some non-ascii characters inside files. This may cause problems with linters requiring only ascii characters, and it's against most of style guides for C++. fixed in #97

Nov 10 '22 10:11 SebastianLuzynski

Hi thanks for pointing this out. This file is generated from https://github.com/oneapi-src/level-zero-spec/blob/master/scripts/templates/api.h.mako

Can you check if non-ascii character is in that file?

Nov 10 '22 12:11 bmyates

Nov 10 '22 13:11 SebastianLuzynski

Thanks! Please open issue/PR in the spec repo. After changes are accepted there, the files in this repo can be regenerated.

Nov 10 '22 13:11 bmyates

@bmyates Commit to level zero spec has been merged.

Nov 30 '22 13:11 SebastianLuzynski

Thanks, next release here will include the changes. We are currently waiting on 1.5 spec to be finalized. It is expected soon.

Nov 30 '22 13:11 bmyates

@SebastianLuzynski If this issue is now resolved, could you either close the bug, or comment what's still an issue?

Nov 21 '23 11:11 eero-t