inductive.js icon indicating copy to clipboard operation
inductive.js copied to clipboard

verbosity handling

Open UniqueFool opened this issue 9 years ago • 3 comments

It seems it's using magic numbers for now (setOptions({ verbosity: 10 })) - wouldn't it make more sense to var verbosity = require('lib/verbosityLevel.js') and then use the key of the object as the value for the hash, i.e.:

setOptions({ verbosity: verbosity.solutionAst })

i.e. to make things more self-explanatory ?

UniqueFool avatar May 21 '16 12:05 UniqueFool

Yeah, you're right.

omphalos avatar May 21 '16 12:05 omphalos

I was just asking because I ended up documenting it that way in the wiki, but then stumbled across the magic numbers instead

UniqueFool avatar May 21 '16 12:05 UniqueFool

I looked over the code and I was using the verbosityLevels object most everywhere but there were a few places where I just set it to 0. I changed that to verbosityLevels.quiet. The verbosity: 10 example you found is from the underscore piece I was working on. I've updated it there as well.

FYI the underscore code is all a work in progress. While working on that I realized that I have to refactor something in the type system to adequately being able to generate underscore.js from unit tests. It's because my handling of polymorphic types isn't sophisticated enough. I haven't gotten around to fixing that bit. If you run underscore-watch.sh you will see that the underscore tests fail. I would suggest maybe staying away from that particular example in the examples directory as it's broken.

omphalos avatar May 21 '16 13:05 omphalos