forrest icon indicating copy to clipboard operation
forrest copied to clipboard

Added get getContentVersionBody and getAttachmentBody

Open danielpetrica opened this issue 1 year ago • 3 comments

Based on code provided in issue https://github.com/omniphx/forrest/issues/179 by @ShintaroNitta and @zack-carlson

danielpetrica avatar Jul 03 '24 13:07 danielpetrica

Drafted as I need to integrate facade and the readme file

danielpetrica avatar Jul 03 '24 13:07 danielpetrica

I tested it with the client credential workflow only

danielpetrica avatar Jul 03 '24 13:07 danielpetrica

Hi I'm using the eloquent package and this library in a site we're developing at work. I found out that we need this code to be able to download files uploaded to sales force with the contentVersion flow. I managed to upload the file but I incurred the same error as in ticket https://github.com/omniphx/forrest/issues/179. Instead of overwriting the class, I think it is more elegant to extend the base class so we can use the method in all authentication classes.

danielpetrica avatar Jul 03 '24 13:07 danielpetrica

Hi @danielpetrica, thanks for the contribution. I'll go and merge this in since it shouldn't be a breaking change for the Web Auth flow.

omniphx avatar Sep 01 '24 06:09 omniphx

Thank you for the merge and for the packet. It's making my job eaier ❤️

danielpetrica avatar Sep 01 '24 11:09 danielpetrica