datatables-bundle icon indicating copy to clipboard operation
datatables-bundle copied to clipboard

feat: add language feature for php8.0, add strong types, adjust tests

Open Chris53897 opened this issue 3 years ago • 2 comments

Hi, this PR addresses the following points.

  • add language feature for php8.0
  • add strong types
  • adjust tests
  • Remove some tests for types that in my eyes are not needed anymore.
  • Fix some tests (see static::getContainer() )

Questions:

  • isValidForSearch($value) Parameter mixed vs string? I changed it to mixed
  • Different return types of configureOptions() void vs OptionsResolver What is the desired behaviour? Should be consistent in my point of view.

There is still one Test not working with symfony6 ORMAdapterEventsTest->testPreQueryEvent() but that should be fixed in an other PR

Chris53897 avatar Mar 17 '22 11:03 Chris53897

I fixed most of this with major maintenance already, except the strong types. The PR should be mergeable still if you rebase I think.

curry684 avatar Aug 10 '22 09:08 curry684

@curry684 Thanks for having a look and maintenance. I will have a look at your changes.

Chris53897 avatar Aug 10 '22 10:08 Chris53897

Stale pull request message

github-actions[bot] avatar Nov 18 '22 22:11 github-actions[bot]