openmicroscopy icon indicating copy to clipboard operation
openmicroscopy copied to clipboard

Use the copy

Open jburel opened this issue 4 years ago • 2 comments

Copy the file if found locally above src

Background:

During the daily build process, an entry is added to etc/omero.properties indicating where to download the artifacts from, e.g. https://merge-ci.openmicroscopy.org/jenkins//job/OMERO-python-superbuild-build/lastSuccessfulBuild/artifact/PACKAGE/dist/ This only works when using DNS.

In the case of the temporary devspace (no DNS the url is set to for example https://github.com/snoopycrimecop/openmicroscopy/blob/snoopycrimecop_ci/etc/omero.properties#L211 but the url points to nothing real ("real" is something like idr1-slot3.o.org:PORT/jenkins/...)

To support the non DNS case, artifacts are copied using the "CopyArtifacts" option in the jenkins job and moved to the directory where src is (location can be modified if there is a more suitable place) The proposed change first looks if the artifact is available locally before using the versions.omero-pypi property.

jburel avatar Jan 28 '22 11:01 jburel

@jburel : can you add some more of the background to the description here? What's triggering the need for the change?

joshmoore avatar Feb 10 '22 13:02 joshmoore

@joshmoore background added to the description

jburel avatar Feb 10 '22 13:02 jburel

Edit: removing exclude label to work on new CI

jburel avatar Apr 27 '23 12:04 jburel

This PR has now been opened for a long time. I suggest that we merge it otherwise the strategy to deploy new ci will not work

cc @pwalczysko

jburel avatar Jul 17 '23 08:07 jburel

The build is green now. https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-build/

pwalczysko avatar Jul 17 '23 10:07 pwalczysko