samples

samples copied to clipboard

Under two circumstances can two distinct instantiations of `impl_ptr` have a copier function convertible to the other `impl_ptr`? This copy assignment operator is templated, but I can't see a situation...

meator

What is the purpose of `unique_impl_ptr(unique_impl_ptr< U, D > &&u)`?

1

I don't understand the purpose of [`unique_impl_ptr(unique_impl_ptr< U, D > &&u)`](https://github.com/oliora/samples/blob/58dead450bdac418fc55dfc512b8411556f51c0e/spimpl.h#L176-L183). `spimpl` seems to care about construction/assignment from not only types identical to T, but also types convertible to it....

meator

Similar to https://github.com/oliora/samples/pull/11.

meator

EDIT: Also fixed both `operator

meator

Likely a bad copy paste from `impl_ptr`. The additional parameter `C1` makes it impossible to use this operator without explicitly specifying all its template types, making it less useful. Sample...

meator