jQuery-switchButton icon indicating copy to clipboard operation
jQuery-switchButton copied to clipboard

Not possible to disable the button?

Open jsndk opened this issue 11 years ago • 5 comments

Nice button, :-) But if i want to disable it, it does not respect the disable="disabled" attribute on the checkBox. Do i need to do something different?

jsndk avatar Oct 27 '14 11:10 jsndk

ah, it's "funny" that you're the first one to even ask for this... it's indeed missing! My feeling is that this code need to be overhauled anyway, so I do accept pull request but do not have much time to invest on the current code... I'm still hoping to create a "switchButton2" script at some point!

olance avatar Oct 27 '14 12:10 olance

hey,

He He, This happens to the best. :-)

You already have a merge request for the readonly feature, and i can use this for the same purpose. (display the value to the user but they can't change it.) so if you accept this merge then im good.

(merge is from kizz246 https://github.com/kizz246 wants to merge 1 commit into olance:master from kizz246:master )

2014-10-27 13:07 GMT+01:00 Olivier Lance [email protected]:

ah, it's "funny" that you're the first one to even ask for this... it's indeed missing! My feeling is that this code need to be overhauled anyway, so I do accept pull request but do not have much time to invest on the current code... I'm still hoping to create a "switchButton2" script at some point!

— Reply to this email directly or view it on GitHub https://github.com/olance/jQuery-switchButton/issues/18#issuecomment-60582978 .

jsndk avatar Oct 27 '14 13:10 jsndk

:)

Okay, I'll find time to review the PR and get everything merged! :+1:

olance avatar Oct 30 '14 05:10 olance

Perfekt 😊

Sendt fra min Windows Phone

-----Oprindelig meddelelse----- Fra: "Olivier Lance" [email protected] Sendt: ‎30-‎10-‎2014 06:58 Til: "olance/jQuery-switchButton" [email protected] Cc: "jsndk" [email protected] Emne: Re: [jQuery-switchButton] Not possible to disable the button? (#18)

:) Okay, I'll find time to review the PR and get everything merged!
— Reply to this email directly or view it on GitHub.=

jsndk avatar Oct 30 '14 06:10 jsndk

Hi! Nice tool indeed :) Did you finally make the change to accept a "disabled" state? Thank you!

mariiine avatar Nov 08 '15 16:11 mariiine