exchain icon indicating copy to clipboard operation
exchain copied to clipboard

register signal of wasm in params keeper

Open xzav3r opened this issue 3 years ago • 1 comments

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • [ ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • [ ] Wrote tests

  • [ ] Updated relevant documentation (docs/)

  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • [ ] Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

xzav3r avatar Oct 11 '22 03:10 xzav3r

Codecov Report

Merging #2587 (e4b0576) into dev (a869d4c) will increase coverage by 0.02%. The diff coverage is 62.50%.

@@            Coverage Diff             @@
##              dev    #2587      +/-   ##
==========================================
+ Coverage   35.99%   36.02%   +0.02%     
==========================================
  Files         399      399              
  Lines       42235    42229       -6     
==========================================
+ Hits        15204    15211       +7     
+ Misses      25939    25929      -10     
+ Partials     1092     1089       -3     
Impacted Files Coverage Δ
x/wasm/keeper/cache.go 24.00% <0.00%> (-1.00%) :arrow_down:
x/wasm/keeper/keeper.go 80.69% <80.00%> (+1.97%) :arrow_up:
app/app.go 80.82% <100.00%> (+0.04%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 11 '22 03:10 codecov-commenter

The same thing has been done in pr https://github.com/okex/exchain/pull/2529, so close this

xzav3r avatar Oct 28 '22 08:10 xzav3r