okta-sdk-nodejs icon indicating copy to clipboard operation
okta-sdk-nodejs copied to clipboard
verified publisher icon okta

feat: Enhance SDK Client to support Client ID and Secret Authorization

Open Astro2024 opened this issue 1 year ago • 10 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Adding Tests
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Documentation changes
  • [ ] Other... Please describe:

What is the current behavior?

Currently, there are two ways to initialize the Okta client within the okta-sdk. The first is using an api token and the second is using a public private key pair.

Issue Number: N/A

What is the new behavior?

This PR allows someone using the okta-sdk to initialize the Okta client using client id and client secret in addition to the previous two methods mentioned.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Reviewers

@jefftaylor-okta

Astro2024 avatar Oct 23 '24 18:10 Astro2024

@ryanbradley

Astro2024 avatar Oct 25 '24 18:10 Astro2024

@jaredperreault-okta Can you have a look at this PR?

jefftaylor-okta avatar Nov 14 '24 18:11 jefftaylor-okta

@bretterer I cleaned up the commits so they would all be verified as per you repo merge rules. Can you re-approve the PR since your initial review was dropped after I cleaned up the commits?

Astro2024 avatar Dec 02 '24 15:12 Astro2024

@bretterer thanks for the review here- for some reason, @Astro2024 and I can't merge this PR. Anything else we need to do? Screenshot 2024-12-04 at 10 56 10 AM

willpots avatar Dec 04 '24 15:12 willpots

@jaredperreault-okta are there any other steps we need to take to get this PR Merged?

Astro2024 avatar Dec 09 '24 13:12 Astro2024

@bretterer @jaredperreault-okta Bump

Astro2024 avatar Dec 20 '24 16:12 Astro2024

Hey, any updates on this? We could really use this. Thanks!

baileywickham avatar Jan 14 '25 17:01 baileywickham

@bretterer @jefftaylor-okta @jaredperreault-okta Is there a timeline for when this PR can be merged or is there currently a moratorium on PR merges?

Astro2024 avatar Jan 21 '25 16:01 Astro2024

@bretterer @jefftaylor-okta @jaredperreault-okta Any updates on when this might be able to go in?

Astro2024 avatar Apr 08 '25 14:04 Astro2024

Any updates on when this can go in?

mplachter avatar Jun 11 '25 03:06 mplachter