okta-react icon indicating copy to clipboard operation
okta-react copied to clipboard

Update README documentation for `<SecureRoute>` incompatibility with React Router v6

Open gavinr-maps opened this issue 2 years ago • 2 comments

Describe the bug

It was discussed here that <SecureRoute> cannot be used with React Router v6. This fact was confirmed by @jaredperreault-okta here, and Jared linked to this sample which does not use the <SecureRoute> component.

Based on the above, <SecureRoute> is not compatible with React Router v6. Given that React Router v6 has been out for almost 2 years, I think the documentation in this project's README should assume that users are using React Router v6 (and thus cannot use <SecureRoute> 😟). That involves:

  1. Updating this sample: image
  2. Updating the wording here image

Reproduction Steps?

See the README links above.

SDK Versions

n/a

Additional Information

No response

gavinr-maps avatar Sep 08 '23 19:09 gavinr-maps

Someone is working on this bug? react-router v6 is up since 2 years now...

Lcharvol avatar Sep 27 '23 14:09 Lcharvol

2,5 years now...

guushamann avatar Feb 07 '24 10:02 guushamann