security-code icon indicating copy to clipboard operation
security-code copied to clipboard

refactor: do plugin universal css agnostic

Open reslear opened this issue 4 years ago • 1 comments

hi @lilianjin, i'm suggest do plugin css agnostic:

  • [ ] remove tailwind classes from plugin
  • [ ] add specific plugin classes like (sc-container, sc-wrapper, sc-input etc...)
  • [ ] add styles to .css for vanilla css (compiled with tailwind) and importing if need [1]
  • [x] add to package.json separate exports for css files
  • [ ] add instruction how to use with tailwind and well-now classes with @apply syntax [2]
  • [x] rewrite to typescript

[1]

// importing styles if need css 
import 'ofcold-security-code/styles.css'
.sc-container {
   display:flex;
   margin-left: auto;
   margin-right: auto;
}

[2]

.sc-container {
   @apply flex flex-direction ml-auto mr-auto
}

reslear avatar Jul 29 '21 13:07 reslear

Thank you for your excellent proposal! I will finish it in some time, and I have other things busy recently.

lilianjin avatar Jul 30 '21 18:07 lilianjin