web icon indicating copy to clipboard operation
web copied to clipboard

Lane indicator not visible with filters

Open GoldMath opened this issue 6 years ago • 4 comments

Current Behavior Capture

Hello, I use a filter of Last 3 months to have a better picture of my recent matches, but actually when you use filters the Lane indicator is not visible.

Expected behavior/code Is this expected? It would be nice to stay visible.

Environment

  • Browser Version: Brave (0.67.125) based on Chromium: 76.0.3809.100
  • OS: Windows 10

Regards,

GoldMath avatar Aug 16 '19 08:08 GoldMath

By default the API call doesn't include this field. We can: Include it in the default set of fields Change the API call to request this field (if we do this, also need to include all the fields we want)

howardchung avatar Aug 17 '19 05:08 howardchung

As a temporary workaround you can filter the matches to a particular role

howardchung avatar Aug 17 '19 05:08 howardchung

@howardchung what do you think about using a GraphQL server for more dynamic access to fields on the core server? Could be a bigger project but would allow us to do more dynamic fetches without any changes on the server. Just an idea since I've been working with Apollo for the last 3 months and it's a blast working with it in the frontend.

bdbch avatar Oct 06 '19 01:10 bdbch

It's been discussed before, see issue https://github.com/odota/core/issues/1495 and PR https://github.com/odota/core/pull/1554

We haven't followed through, but I'm not opposed to deploying graphql on the server, and using it on the web API where it makes sense.

howardchung avatar Oct 06 '19 06:10 howardchung