documentation icon indicating copy to clipboard operation
documentation copied to clipboard
verified publisher icon odoo

[IMP] developer/frontend: hotkey service & hook

Open brboi opened this issue 3 years ago • 6 comments

brboi avatar Mar 22 '22 09:03 brboi

@odoo/javascript-doc-review

brboi avatar Mar 22 '22 09:03 brboi

Pull request status dashboard.

robodoo avatar Mar 22 '22 09:03 robodoo

mostly approve this PR

ged-odoo avatar Mar 28 '22 13:03 ged-odoo

mostly approve this PR

Is this ready for merge?

AntoineVDV avatar Apr 29 '22 09:04 AntoineVDV

branch is red!

ged-odoo avatar May 17 '22 08:05 ged-odoo

branch is red!

Violets are blue ;-)

The branch is red due to the following error:

/data/build/documentation/content/developer/reference/frontend/services.rst:579: WARNING: duplicate function description of add, other function in developer/reference/frontend/services

This is because the add() method in the hotkey service has the same name as the add() method from the notification service.

You suggested to find a way to namespace the RST JS Domain. It is done through the .. js:module admonition. See: https://www.sphinx-doc.org/en/master/usage/restructuredtext/domains.html#the-javascript-domain

I force pushed the branch trying this approach, tell me what you think.

brboi avatar May 18 '22 12:05 brboi