fancy-test icon indicating copy to clipboard operation
fancy-test copied to clipboard

Loosen typings for nock host to string | Regexp | Url

Open dan-barrett opened this issue 5 years ago • 0 comments

https://github.com/oclif/fancy-test/blob/7a82fdd232d4ca5cc4c34f83551dc2fb2de457b2/src/nock.ts#L5

This library wraps nock in a very helpful way. However, in the above line of code, the type for the nock host is too restrictive. This should be changed from string to string | Regexp | Url, which is what the underlying nock constructor takes:

https://github.com/nock/nock/blob/749ec7f518078178c8080600494577073ee7a79a/types/index.d.ts#L11

dan-barrett avatar Jul 16 '20 14:07 dan-barrett