dev-cli icon indicating copy to clipboard operation
dev-cli copied to clipboard

feat(readme)!: fix markdownlint violations

Open felipecrs opened this issue 5 years ago • 6 comments

This fixes many markdownlint violations found in the generated docs.

felipecrs avatar Sep 19 '20 19:09 felipecrs

Thanks for the contribution! Before we can merge this, we need @felipecrs to sign the Salesforce.com Contributor License Agreement.

salesforce-cla[bot] avatar Sep 19 '20 19:09 salesforce-cla[bot]

Circle CI is failing due to a PGP error, I believe it has nothing to do with this PR.

https://app.circleci.com/pipelines/github/oclif/dev-cli/398/workflows/ba4e23fc-0aa5-4c47-a826-bc2d2967f64a/jobs/2032/parallel-runs/0/steps/0-105

felipecrs avatar Sep 19 '20 19:09 felipecrs

@felipecrs thanks for the PR! However, we don't use markdownlint in this project. Likewise, markdownlint doesn't define a spec/standard.

RasPhilCo avatar Nov 19 '20 21:11 RasPhilCo

Despite that, I don't believe there is any drawback of applying this PR.

felipecrs avatar Nov 19 '20 21:11 felipecrs

I actually need it, because the way it works today, the hierarchy of the titles and subtitles in the .md files are not being correctly detected in Docusaurus for example (when using multi md files for each command).

felipecrs avatar Nov 19 '20 21:11 felipecrs

Gotcha. We have a major bump for this package scheduled soon, we'll include it there.

RasPhilCo avatar Nov 19 '20 21:11 RasPhilCo