dev-cli icon indicating copy to clipboard operation
dev-cli copied to clipboard

Links in readme assumes that the version tag always has a `v` prefix

Open shazron opened this issue 6 years ago • 2 comments

Line: https://github.com/oclif/dev-cli/blob/9c9be3dff5e063b9ce06feb700c79317a6e84e21/src/commands/readme.ts#L170

The link assumes that the tag has the v prefix. If you set tag-version-prefix="" in your .npmrc, you will not have the v prefix when tagging via npm version.

This module should read the tag-version-prefix setting for npm instead of hard-coding the v.

shazron avatar Nov 12 '19 17:11 shazron

Here's how np does it: https://github.com/sindresorhus/np/blob/1c9d05f6f4eab40f8a5a5c71893d6a6c997f08dc/source/util.js#L51

shazron avatar Nov 12 '19 17:11 shazron

Good idea. Work around for now it to set package.json oclif.repositoryPrefix.

RasPhilCo avatar Nov 12 '19 18:11 RasPhilCo