dune icon indicating copy to clipboard operation
dune copied to clipboard
verified publisher icon ocaml

Add root and build context to dune describe output

Open zpyemont opened this issue 3 years ago • 4 comments

For ROTOR we would like to have access to the original source files, not their locations within the build directory. To get this, we need the build context and the workspace root.

This is an updated PR of https://github.com/ocaml/dune/pull/3834 and https://github.com/ocaml/dune/pull/6092, the latter of which I closed by mistake (sorry).

In this PR the build prefix and the path to the workspace root are added the the beginning of the output of dune describe.

@esope, would you be able to review this updated version? Thanks in advance.

zpyemont avatar Sep 07 '22 21:09 zpyemont

We have addressed the code review comments now.

reubenrowe avatar Sep 15 '22 14:09 reubenrowe

Can you please add an entry to CHANGES.md?

esope avatar Sep 19 '22 10:09 esope

Done @esope

reubenrowe avatar Sep 19 '22 19:09 reubenrowe

Thanks. This is fine for me. I guess we need yet somebody else's input. @rgrinberg ?

esope avatar Sep 20 '22 06:09 esope

@rgrinberg can we make some progress on this PR ?

esope avatar Oct 09 '22 12:10 esope

As a reviewer, you can formally approve the PR when you deem it's ready.

rgrinberg avatar Oct 09 '22 19:10 rgrinberg