Brice
I believe all discussion items have been addressed now.
I'm reviewing these unit test failures now.
@jcnelson @gregorycoppola Assuming the unit tests pass, this PR is ready for a re-review.
🤔 the stack depth check in the parser is failing, but I haven't changed anything in the parser in this PR... Somehow the stack is growing faster than it is...
> I noticed this too in #3358. Still looking into it, but I don't think `parser::v2` implements the `VaryStackDepthChecker` pass? There is no call to the `VaryStackDepthChecker` pass, but the...
The failing tests hits the stack overflow after a depth of 67 and the cutoff in the check is 69 (`AST_CALL_STACK_DEPTH_BUFFER + MAX_CALL_STACK_DEPTH`).
Thanks for the final reviews and approvals! Before merging, I will address those minor comments and add a few more tests.
And resolve conflicts
~~I think this is finally ready to be merged!~~ Oops, typo from merge conflict fix. Fixing now...
There is not currently support for chocolatey.