Brice

Results 277 comments of Brice

Gina, @jcnelson, or @MarvinJanssen -- can we get a ~~sing-off~~ sign-off from the steering committee added, then we should be ready to merge! EDIT: fixed typo, but you three can...

I have a concern about the real-world security of the execution plan commitment, because in practice it will be so difficult to understand, that users will just ignore it and...

> Why does this SIP require a community vote? This has been a discussion amongst the CABs, SIP editors, etc. and the current _consensus_ is that anything that is consensus...

Also, noting that the SIP doesn't have to be consensus breaking to require a community vote -- some SIPs might want a community vote even if not consensus changing --...

I'm still checking on a couple of the integration tests, but @kantai, when you have some time, could you take a look at the approach here and let me know...

Thanks for the review @jcnelson. I've addressed the simple comments and will work on adding those tests you requested. I also added an integration test since you reviewed which was...

Thanks for the review @kantai. Will address these comments shortly. While adding the tests @jcnelson requested, I realized that I never implemented the analysis error when using `block-height` in Clarity...

Ok, I added some more tests in 1bff5b7ce7828248672b74731a8855fa787b06b9. I'm not sure why `test_block_heights_across_versions` is failing yet. I need to resolve that and then add one more test for: > Can...

> Can a Clarity 1 and Clarity 2 contract perform the above using at-block to call into the Clarity 3 contract from a block that's before epoch 3.0? Is this...

@wileyj Can we remove the "CI / Rust Format (pull_request_review)" from the required checks?