UI: Fix multitrack video autoconfig option

[lexano-ivs]

Description

When using the Auto-Configuration Wizard with the Twitch service, testing for Enhanced Broadcasting would always run, even if deselected. Add a conditional check to only run the test if selected.

Motivation and Context

The AutoConfig wizard would force Twitch Enhanced Broadcasting to be enabled even if users did not want it.

Bug report was filed at https://github.com/obsproject/obs-studio/issues/11177

How Has This Been Tested?

Tested locally with my Twitch account, with several iterations of enabling/disabling the "Test Enhanced Broadcasting" option in the wizard.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• [x] My code has been run through clang-format.
• [x] I have read the contributing document.
• [x] My code is not on the master branch.
• [x] The code has been tested.
• [x] All commit messages are properly formatted and commits squashed where appropriate.
• [x] I have included updates to all appropriate documentation.

[Gol-D-Ace]

Edit: Found another way to still have Enhanced Broadcasting enabled when it shouldn't be.

Run a configuration with Prefer hardware encoding, Estimate bitrate with bandwidth test and test enhanced broadcasting. Once the bandwidth test is done press back.

Disable prefer hardware encoding and click next.

After the test enhanced broadcasting will be enabled.

Edit 2: This seems to happen regardless of the options chosen. Even without prefer hardware encoding this still happens when a test was run with enhanced broadcasting. previously.

---

Disabling the checkbox for "Test Enhanced Broadcasting" ensures that it doesn't get used.

Disabling the "Prefer Hardware Encoding" checkbox also makes sure that Enhanced Broadcasting can't be enabled.

---

Further notes not regarding the bug this PR is trying to fix

Only concern I'm personally having is that disabling the checkbox for bandwidth testing does no further testing if multi track video is really working. Are other checks here in place?

Disabling the bandwidth test also lets you set a video Bitrate which will get ignored for enhanced broadcasting.

[Gol-D-Ace]

This is all i was able to find so far.

[Gol-D-Ace]

Shall I open new issues or how do we want to handle that?

[RytoEX]

Shall I open new issues or how do we want to handle that?

If they still occur after this PR, then feel free to submit new Issues.