obs-studio icon indicating copy to clipboard operation
obs-studio copied to clipboard

UI: Output timer bug

Open Sugam-Chand-M opened this issue 1 year ago • 1 comments

Description

Output Timer for Recording dosen't update from Stop -> Start even after the timer expires when the Output Timer dialog is closed. Issue - #10900

Motivation and Context

This PR aims at proper updating of buttons when the timer is expired and even when the Dialog is closed. Fixes the Issue - #10900

How Has This Been Tested?

Tested manually in Windows 11. Added a video drive link - Video Link of the fix working

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code has been run through clang-format.
  • [x] I have read the contributing document.
  • [ ] My code is not on the master branch.
  • [x] The code has been tested.
  • [x] All commit messages are properly formatted and commits squashed where appropriate.
  • [x] I have included updates to all appropriate documentation.

Sugam-Chand-M avatar Jul 01 '24 15:07 Sugam-Chand-M

The same bug is on streaming timer.

... void OutputTimer::StreamTimerStop() { streamingAlreadyActive = false; if (!isVisible() && streamingTimer->isActive() == false) return; if (streamingTimer->isActive()) ...

ShaMAD avatar Jul 04 '24 15:07 ShaMAD