react-native-progress icon indicating copy to clipboard operation
react-native-progress copied to clipboard

Circle shows incorrectly when progress is 0 and strokeCap is round or square

Open peterkuiper opened this issue 5 years ago • 0 comments

This is a regression of https://github.com/oblador/react-native-progress/pull/135.

Simple fix (without digging into it further, only works with animated={false}):

diff --git a/node_modules/react-native-progress/Circle.js b/node_modules/react-native-progress/Circle.js
index fdb793f..7067b71 100644
--- a/node_modules/react-native-progress/Circle.js
+++ b/node_modules/react-native-progress/Circle.js
@@ -150,7 +150,7 @@ export class ProgressCircle extends Component {
           ) : (
             false
           )}
-          {!indeterminate ? (
+          {!indeterminate && progress > 0 ? (
             <Shape
               fill={fill}
               radius={radius}

peterkuiper avatar Apr 30 '20 13:04 peterkuiper