objectiv-analytics icon indicating copy to clipboard operation
objectiv-analytics copied to clipboard
verified publisher icon objectiv

Doctests for feature-engineering example notebook

Open ivarpruijn opened this issue 3 years ago • 1 comments

Reformats the feature-engineering example notebook, and adds doctests.

ivarpruijn avatar Sep 21 '22 19:09 ivarpruijn

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar Sep 21 '22 19:09 review-notebook-app[bot]

In this notebook the column name of root locations is root, it could be more clear for the users if we change in the text all the mentions of root_location(s) to root location(s).

vard-obj avatar Sep 23 '22 09:09 vard-obj

In this notebook the column name of root locations is root, it could be more clear for the users if we change in the text all the mentions of root_location(s) to root location(s).

Good idea, done in https://github.com/objectiv/objectiv-analytics/pull/1280/commits/44580260125c1338e0ccb7453dfef1c19e337ff1

ivarpruijn avatar Sep 25 '22 12:09 ivarpruijn