eo icon indicating copy to clipboard operation
eo copied to clipboard
verified publisher icon objectionary

Build error with -Werror

Open victor-yacovlev opened this issue 3 years ago • 10 comments

OpenJDK 18 on macOS/aarch64 generates build fatal warnings "non-transient instance field of a serializable class declared with a non-serializable type" due to some classes do not implement Serializable interface.

Classes/interfaces that must implement Serializable:

  • interface org.eolang.Phi
  • all generated classes extending org.eolang.PhDefault, also these classes must provide serialVersionUID.

victor-yacovlev avatar Aug 05 '22 06:08 victor-yacovlev

@Graur please, take care of this or delegate. I think we should add java version 18 to mvn.yml GitHub action, to make sure this bug won't happen again

yegor256 avatar Aug 05 '22 06:08 yegor256

@kerelape please take this task, the budget is 30 minutes

Graur avatar Aug 05 '22 10:08 Graur

@kerelape What's up with this task?

Graur avatar Sep 14 '22 13:09 Graur

@Graur maven does not understand -W

kerelape avatar Sep 15 '22 09:09 kerelape

@kerelape Did you try to rise up java version to 18?

Graur avatar Sep 15 '22 11:09 Graur

@Graur yes... It is openjdk 18, macos 1.13.6. Maybe I miss something? I have only updated the jdk and ran mvn ..., is there something else I need to do?

kerelape avatar Sep 15 '22 12:09 kerelape

@kerelape Did you try to do this:

Classes/interfaces that must implement Serializable:

  • interface org.eolang.Phi
  • all generated classes extending org.eolang.PhDefault, also these classes must provide serialVersionUID.

?

Graur avatar Sep 15 '22 12:09 Graur

@kerelape Did you try to do this:

Classes/interfaces that must implement Serializable:

  • interface org.eolang.Phi
  • all generated classes extending org.eolang.PhDefault, also these classes must provide serialVersionUID.

?

I did make that. But I cannot check if it works because without that it works too.

kerelape avatar Sep 15 '22 13:09 kerelape

@kerelape If so, just send us a pull request with mvn.yml changes and that's it

Graur avatar Sep 15 '22 13:09 Graur

@kerelape If so, just send us a pull request with mvn.yml changes and that's it

I am sorry, I will do so now

kerelape avatar Sep 15 '22 14:09 kerelape

@kerelape @Graur what's up with this one?

yegor256 avatar Nov 13 '22 04:11 yegor256

@kerelape Do you have any progress here?

Graur avatar Nov 14 '22 08:11 Graur

@Graur time to close this one?

yegor256 avatar Mar 05 '23 05:03 yegor256

@yegor256 @Graur All changes are in open PR. However there is an issue with tests on Win/JDK18.

mximp avatar Mar 06 '23 07:03 mximp