Fix checkstyle warnings for `ExprReduce`

[mximp]

Split from https://github.com/objectionary/eo/issues/739

Refactor the class to pass all checkstyle checks. Current warnings:

[INFO] Checkstyle: src/main/java/org/eolang/ExprReduce.java[83]: More than 3 parameters (found 5). (ParameterNumberCheck)
[INFO] Checkstyle: src/main/java/org/eolang/ExprReduce.java[104]: More than 3 parameters (found 4). (ParameterNumberCheck)

[mximp]

@potatmen please assist

[potatmen]

@mximp when does this warning occur? During the compiling like this mvn clean test?

[mximp]

You can run qulice:check maven goal on eo-runtime after commenting checkstyle exclusion in pom.xml:

<profiles>
    <profile>
      <id>qulice</id>
      <build>
        <plugins>
          <plugin>
            <groupId>com.qulice</groupId>
            <artifactId>qulice-maven-plugin</artifactId>
            <configuration>
              <excludes>
<!--                <exclude>checkstyle:.*</exclude>-->
                <exclude>checkstyle:/src/test/.*</exclude>
                <exclude>pmd:.*</exclude>
              </excludes>
            </configuration>
          </plugin>
        </plugins>
      </build>
    </profile>
  </profiles>

[mximp]

Enable Checkstyle validation for eo-runtime

In eo-runtime/pom.xml comment out exclude:

<profiles>
    <profile>
      <id>qulice</id>
      <build>
        ...
            <artifactId>qulice-maven-plugin</artifactId>
            <configuration>
              <excludes>
<!--                <exclude>checkstyle:.*</exclude>-->
                <exclude>checkstyle:/src/test/.*</exclude>
                <exclude>pmd:.*</exclude>
              </excludes>
            </configuration>
      ...
      </build>
    </profile>
  </profiles>

Run qulice:check goal

Within eo-runtime folder execute the following command:

mvn qulice:check -P qulice

This will produce the list of errors from Checkstyle. Find the ones you are interested in.

[potatmen]

@mximp Thanks for the clarification

[potatmen]

@mximp done https://github.com/objectionary/eo/pull/1032

[mximp]

Thanks @potatmen!

[potatmen]

@mximp I haven't actually fixed it yet

[mximp]

@potatmen was the merge for?

[mximp]

@yegor256 this one is completed.