eo icon indicating copy to clipboard operation
eo copied to clipboard

eo.skip option for eo-maven-plugin

Open yegor256 opened this issue 3 years ago • 3 comments

Let's introduce eo.skip option for our Maven plugin. So that it would be possible to do this in XML:

<configuation>
  <skip>true</skip>
</configuration>

Also, from command line:

$ mvn -Deo.skip

yegor256 avatar Aug 10 '22 10:08 yegor256

@mximp should be pretty easy to implement, please help

yegor256 avatar Aug 10 '22 10:08 yegor256

@yegor256 what should it skip?

mximp avatar Aug 10 '22 11:08 mximp

@mximp the execution of a mojo. Just return and that's it, if the flag is set.

yegor256 avatar Aug 10 '22 11:08 yegor256

@OlesiaSub please assist with this.

mximp avatar Aug 16 '22 11:08 mximp

@mximp @yegor256 could you please give a more detailed explanation of the idea or maybe an example of what should happen? I didn't quite get it.

OlesiaSub avatar Aug 16 '22 11:08 OlesiaSub

@OlesiaSub If you check pom.xml in eo-runtime module you will see eo-maven-plugin configuration. It's required to be able to supply <skip/> option in configuration to suppress execution of plugin goals. Defaulted to false. All plugin logic is in eo-maven-plugin module. Please check SafeMojo class which is common for all plugin goals. I believe skip option check can be placed there.

mximp avatar Aug 16 '22 16:08 mximp

@mximp thanks! Just to clarify, should skip option suppress execution of all goals at once or should it be specific for particular goals?

OlesiaSub avatar Aug 17 '22 09:08 OlesiaSub

@OlesiaSub Execution of all goals

mximp avatar Aug 17 '22 11:08 mximp

@yegor256 all is done. The task can be closed.

mximp avatar Aug 24 '22 15:08 mximp

@mximp @OlesiaSub thanks!

yegor256 avatar Aug 24 '22 16:08 yegor256