python-minecraft-clone icon indicating copy to clipboard operation
python-minecraft-clone copied to clipboard
verified publisher icon obiwac

Chunk Mesh Generation Optimization

Open OrdinaryDev83 opened this issue 2 years ago • 4 comments

  • added a return case if the block is surrounded by 8 full blocks
  • (revert) ~~changed it to be parallelized with Thread Pooling~~ (which I gave up because the performance was worse)

Changes suggested by ChatGPT 4, coded and adapted it. Tell me if you see an improvement in performance.

OrdinaryDev83 avatar May 09 '23 14:05 OrdinaryDev83

Hey! Thanks for the PR :)

I saw you made 2 others, #94 and #95 - could you clarify which ones you'd like reviewed and potentially merged?

obiwac avatar May 10 '23 00:05 obiwac

Sure, #94 and #95 were closed because I updated the code to be clearer, #96 is the only PR to merge.

OrdinaryDev83 avatar May 10 '23 09:05 OrdinaryDev83

Am I supposed to commit the change ?

OrdinaryDev83 avatar May 14 '23 06:05 OrdinaryDev83

yes

well ideally you'd squash but I'll do that for you, no worries

obiwac avatar May 14 '23 11:05 obiwac