python-minecraft-clone icon indicating copy to clipboard operation
python-minecraft-clone copied to clipboard

[Community] Loading screen and menu screen and pause screen

Open ajh123 opened this issue 3 years ago • 26 comments

Currently the menu background is not tilled and the single player button once clicked the game freezes then the world loads. Buttons do not work properly if window scaled Still execute main.py to run it

ajh123 avatar Feb 06 '22 12:02 ajh123

The world saving is defiantly quicker than the loading

ajh123 avatar Feb 06 '22 15:02 ajh123

There is no joystick support for the buttons yet :(

ajh123 avatar Feb 06 '22 15:02 ajh123

Cool! I'll check it out in a bit.

The world saving is defiantly quicker than the loading

That makes sense, all saving does is save block ID's of modified chunks, whereas loading has to load every chunk & generate their meshes, which is the most computationally expensive part.

There is no joystick support for the buttons yet :(

@drakeerv

obiwac avatar Feb 06 '22 18:02 obiwac

Thank you, will try do them :)

ajh123 avatar Feb 06 '22 18:02 ajh123

how do i merge them into my branch?

ajh123 avatar Feb 06 '22 18:02 ajh123

Pardon, how do you merge what into your branch?

obiwac avatar Feb 06 '22 18:02 obiwac

your sugesstions

ajh123 avatar Feb 06 '22 18:02 ajh123

There is no joystick support for the buttons yet :(

There should be? Idk it works for me

drakeerv avatar Feb 06 '22 18:02 drakeerv

@drakeerv but no support for my GUI clickable buttons yet

ajh123 avatar Feb 06 '22 18:02 ajh123

Ah I will try to get it working if I have free time

drakeerv avatar Feb 06 '22 18:02 drakeerv

your sugesstions

Ah well you can't "merge" those. You can address them by simply committing to your branch though.

obiwac avatar Feb 06 '22 18:02 obiwac

I recommend adding the "Loading world" text just when clicking on "singleplayer" to prevent people getting confused why the game is suddendly freezing

Jukitsu avatar Feb 06 '22 18:02 Jukitsu

@Jukitsu I will do that once I've done the other stuff

ajh123 avatar Feb 06 '22 18:02 ajh123

on_resize is missing on the main window

Jukitsu avatar Feb 06 '22 19:02 Jukitsu

"refresh rate" is unnecessary

Jukitsu avatar Feb 06 '22 19:02 Jukitsu

and toggle fullscreen needs "window.set_fullscreen" isntead of self.set_fullscreen

Jukitsu avatar Feb 06 '22 19:02 Jukitsu

@Jukitsu quick tip: you can make a review for that kinda stuff instead of putting everything into individual comments

obiwac avatar Feb 06 '22 20:02 obiwac

Most things are done now

ajh123 avatar Feb 13 '22 11:02 ajh123

Will take a look later today. Could you tell me which changes you made to the world save? There seem to be some conflicts.

obiwac avatar Feb 14 '22 09:02 obiwac

Just added a hidden jukebox somewhere to find. it's quite easy to find tho

ajh123 avatar Feb 14 '22 16:02 ajh123

Right. I'll have to see if there's a way/write a program to easily merge Minecraft worlds because obviously git can't do that on its own 😄

obiwac avatar Feb 14 '22 16:02 obiwac

Still don't have a working on_resize implementation for the menus/buttons but the main game sill rezies

ajh123 avatar Feb 14 '22 16:02 ajh123

here's a good font: https://www.dafont.com/grand9k-pixel.font (click download btn there)

then use font in pyglet

abhra2020-smart avatar Feb 26 '22 20:02 abhra2020-smart

Looking good!

A couple other things I wanted to note:

  • When the game starts loading, it should be paused by default.
  • Resizing doesn't work properly anymore (on_resize removed?).

Overall nice work!

In Minecraft, that's not how it works (as far as I know). It is not paused by default (when I say paused, I mean the pause menu is on screen).

abhra2020-smart avatar Feb 26 '22 20:02 abhra2020-smart

Just added a hidden jukebox somewhere to find. it's quite easy to find tho

wdym? easter egg? noice

abhra2020-smart avatar Feb 26 '22 20:02 abhra2020-smart

In Minecraft, that's not how it works (as far as I know). It is not paused by default (when I say paused, I mean the pause menu is on screen).

If the world is still loading, then I do think it should be paused for better user experience.

obiwac avatar Feb 26 '22 20:02 obiwac

The code is not proper. It crashes the whole computer, windows 11, python v 3.9

@aniketm32012 The last time I tried it, it did work. But that was ages ago and pyglet may of changed somethings. Does the normal version (from obiwac) work?

ajh123 avatar Mar 22 '23 08:03 ajh123

Closing in favour for #104

ajh123 avatar Dec 25 '23 20:12 ajh123