spec icon indicating copy to clipboard operation
spec copied to clipboard

Question on required 'resources' attribute

Open clareliguori opened this issue 6 years ago • 2 comments

I noticed that the container resources attribute is marked as required in the spec. Is it intended to be required? https://github.com/oam-dev/spec/blob/master/3.component_model.md#container

But none of the component schematic examples in this repo have resources configuration: https://github.com/oam-dev/samples

Similarly there are examples in the Rudr repo without resources config, and the implementation has default values for CPU and memory requirements. https://github.com/oam-dev/rudr/blob/master/examples/voting/components.yaml https://github.com/oam-dev/rudr/blob/master/src/schematic/component.rs#L567-L579

clareliguori avatar Jan 17 '20 21:01 clareliguori

Ref https://github.com/oam-dev/spec/issues/58, https://github.com/oam-dev/spec/issues/182, and https://github.com/oam-dev/rudr/pull/435.

We sort of ended up with different opinions. Time to revisit it.

hongchaodeng avatar Jan 17 '20 21:01 hongchaodeng

We still have an open PR for this: #218

vturecek avatar Jan 21 '20 19:01 vturecek