craft-scripts icon indicating copy to clipboard operation
craft-scripts copied to clipboard

Support Local Asset Sync

Open mattclements opened this issue 7 years ago • 4 comments

Similar to REMOTE_DB_USING_SSH, offer the ability to locally sync assets such as when staging/live is on the same environment (i.e. without requiring SSH) via a new flag REMOTE_ASSETS_USING_SSH

mattclements avatar Sep 18 '18 19:09 mattclements

So this already works if staging and live are on the same server; the server just ssh's into itself.

The reason I kept it this way is to keep the code path pure/simple. I'll have a look at the PR tho.

khalwat avatar Sep 18 '18 19:09 khalwat

Thanks @khalwat - the issue is that a user needs to then copy their Public Key (for the web server user) into the same users authorized_keys to let this work. The pull request removes the requirement for this, which allows the scripts to be more easily adopted en-mass

mattclements avatar Oct 24 '18 06:10 mattclements

This is very useful for my setup @khalwat - is this something you are likely to merge?

terryupton avatar Oct 29 '18 15:10 terryupton

I want to have a good review of it, but I'm not opposed to the idea, as long as it isn't adding an additional code path (which it doesn't appear to be).

khalwat avatar Oct 29 '18 23:10 khalwat