components icon indicating copy to clipboard operation
components copied to clipboard

Feature: Show threads by ID

Open bmulholland opened this issue 3 years ago • 2 comments

Code changes

We have a list of threads that we've assembled using our app's "secret sauce," and now want to show the user this curated lists of threads as kind of an automatically created folder. We don't want to create folders or labels for the user, because that gets into preferences of if (and how) they'd like their email data modified.

We also want to make the mailbox UI interactive, which is to say, we want the Nylas component to run HTTP requests. It should load the body of emails, contact data, and write data back, allowing for star/unstar etc. The only current way to display a specific set of threads in the Mailbox is to supply all_threads, but that requires optimistic loading of all data (very slow), and disables all the interactive parts of the component.

This change, previously discussed with Hazik Azfal, adds support for passing in a list of thread IDs, which fulfills all requirements. We're about to deploy the mailbox component to production with this modification (along with other changes in other PRs)

Closes https://github.com/nylas/components/issues/439

Readiness checklist

  • [ ] Added changes to component CHANGELOG.md
  • [ ] New property added? make sure to update component/src/properties.json
  • [ ] Cypress tests passing?
  • [ ] New cypress tests added?
  • [ ] Included before/after screenshots, if the change is visual

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

bmulholland avatar Oct 14 '22 10:10 bmulholland

@bmulholland is attempting to deploy a commit to the Nylas Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 14 '22 10:10 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
components ❌ Failed (Inspect) Oct 18, 2022 at 2:43PM (UTC)

vercel[bot] avatar Oct 14 '22 10:10 vercel[bot]