components icon indicating copy to clipboard operation
components copied to clipboard

[WIP] Svelte Child components

Open yifanplanet opened this issue 4 years ago • 1 comments

Code changes

Current issues:

  • [x] Some styles are missing from the compiled bundle, we think it might be related to svelte having some difficulty compiling scss with this workaround https://github.com/nylas/components/pull/350/files#diff-5330159ddf6d2bb56f34d850d145df3e3962f342ff29992dabe6df366b8ffc22R103
  • [x] Need to figure out the order of operations for this rollup config, it doesn't seem to find the bundled css and it errors when trying to import https://github.com/nylas/components/pull/350/commits/638fbf6adac35f3ac8772b826a98c0fc592fefec#diff-5330159ddf6d2bb56f34d850d145df3e3962f342ff29992dabe6df366b8ffc22R107

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

yifanplanet avatar Jan 20 '22 21:01 yifanplanet

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nylas/components/6JefoW5VmRaGYLgQFj54HePBbcZj
✅ Preview: https://components-git-yifan-pooja-fix-composer-nylas-comp-2bd1f6-nylas.vercel.app

vercel[bot] avatar Jan 20 '22 21:01 vercel[bot]