Hirokazu MORIKAWA

Results 90 comments of Hirokazu MORIKAWA

Probably not, but is swig's PTAH correct? > [ 38%] Building CXX object src/javascript/CMakeFiles/mraajs.dir/CMakeFiles/mraajs.dir/mraajsJAVASCRIPT_wrap.cxx.o In file included from /home/ens-ife/Logiciels/IoT/mraa/build/src/javascript/CMakeFiles/mraajs.dir/mraajsJAVASCRIPT_wrap.cxx:1822: /home/ens-ife/Logiciels/IoT/mraa/api/mraa/gpio.hpp: In static member function ‘static void mraa::Gpio::v8isr(uv_work_t*, int)’: /home/ens-ife/Logiciels/IoT/mraa/api/mraa/gpio.hpp:179:63: error:...

I tested swig with the "--enable-cpp11-testing" option, and mraa and upm were able to build without any problems. ``` checking whether to attempt to enable C++11 testing... yes checking whether...

> It seems that -DCMAKE_CXX_STANDARD=14 is crucial ! 5why not 17 insteadof 14 ?) I set the number to 14 in order to support node.js v16. No other intentions.

>I checked -DCMAKE_CXX_STANDARD=14 and -DCMAKE_CXX_STANDARD=17 no difference ! probably we may choose 17 as it is the more uptodate? I think we should choose conservative options. Again. I will explain...

I recommend that you submit a pull request for the gcc10 patch.

>I recommend that you submit a pull request for the gcc10 patch. The same patch had already been opened. https://github.com/eclipse/mraa/pull/1012

This seems to be working. ``` --- a/api/mraa/gpio.hpp +++ b/api/mraa/gpio.hpp @@ -175,7 +175,11 @@ v8::Local argv[] = { SWIGV8_INTEGER_NEW(-1) }; #if NODE_MODULE_VERSION >= 0x000D v8::Local f = v8::Local::New(v8::Isolate::GetCurrent(), This->m_v8isr); +#if...

@Propanu This is a case of applying the patch we are considering in SWIG. https://github.com/swig/swig/pull/1746 I've applied these patches to the OpenWrt packages I maintain and so far there don't...

Lack of "SWIG_V8_VERSION" consistency seems to be the root cause of this problem. https://github.com/eclipse/mraa/issues/1040#issuecomment-828957352

While checking the handling of "SWIG_V8_VERSION" on the SWIG side, I made a patch for mraa and upm. SWIG: https://github.com/swig/swig/pull/2011#issuecomment-830914401 MRAA: https://github.com/eclipse/mraa/pull/1064 UPM: https://github.com/eclipse/upm/pull/703