nvpro_core

nvpro_core copied to clipboard

Fixes: ``` vk_meshlet_cadscene_app: gl_vk_meshlet_cadscene/nvpro_core/nvvk/memorymanagement_vk.cpp:692: void* nvvk::DeviceMemoryAllocator::map(nvvk::AllocationID, VkResult*): Assertion `block.mappable' failed. ```

marcinslusarz

`cmake/find/FindVulkanSDK.cmake` contains the following code for obtaining the path to the Vulkan SDK headers: ```cmake if(EXISTS "${VULKANSDK_ROOT_DIR}/Include/vulkan/vulkan.h") SET(VULKANSDK_INCLUDE_DIR "${VULKANSDK_ROOT_DIR}/Include" CACHE PATH "path") else() SET(VULKANSDK_INCLUDE_DIR "${VULKANSDK_ROOT_DIR}" CACHE PATH "path") endif() ```...

Triang3l

How to use fileformats/nv_dds and fileformats/nv_ktx

2

Hello! How to load .dds and .ktx files to vulkan image with fileformats/nv_dds and fileformats/nv_ktx? Can you show small example?

tigrazone

FindVulkanSDK not finding glslangValidator/glslc on Linux

2

I just tried to compile vk_mini_path_tracer on my Linux machine and ran into an issue with FindVulkanSDK. I specified the location of my VulkanSDK via the VULKAN_SDK environment variable, and...

timo-oster

Error when compiling with clang on windows.

2

When trying to compile a simple project using nvpro_core with clang on windows i run into the error below. Commenting out the relevant section in resources.rs (ln 59-63) has fixed...

ThomasConrad

Possible memory hazard on depth buffer in AppBaseVk?

1

https://github.com/nvpro-samples/nvpro_core/blob/8096be945319118ab8ca8ce873d1ee46c387e8ac/nvvkhl/appbase_vk.cpp#L226 As shwon above line, only one depth buffer is shared by mutliple swap chain frame buffers in `nvvkhl::AppBaseVk` class. But it seems there is nothing that prevents more than...

donguklim

fixed error with format strings

3

A bunch of missing format strings caused the library to not compile for me (CMake 3.29.2, nixos) This PR fixes this issue by adding the format literals.

CDaut

overbrights

6

I have a [scene](https://drive.google.com/file/d/1vnBy3xDVjOaeAVANaPAfRsfQnlmHAfgL/view?usp=sharing) which rendered overbright. Is it posible to autoexposure or use all lights power for automatically balance of lights in scene. In sky mode all looks ok...

tigrazone

When VkSurfaceCapabilitiesKHR.maxImageCount is 0, there is no limit on the number of images. This was being treated as a limit of 0.

tchatow

Usage of memcmp in operator== problematic

3

Hi, I'm using nvpro_core code in combination with the Vulkan C++ wrapper in our code. I recently ran valgrind on it and found an issue. nvpro_core is using `memcmp` to...

timo-oster