nvim-tree.lua icon indicating copy to clipboard operation
nvim-tree.lua copied to clipboard

feat(#1851): persist bookmarks

Open xiantang opened this issue 1 year ago • 12 comments

close https://github.com/nvim-tree/nvim-tree.lua/issues/1851#issue-1508665849

xiantang avatar Dec 22 '24 06:12 xiantang

any updates?

HadyMash avatar Feb 15 '25 12:02 HadyMash

any updates?

I'm happy with this providing the above is addressed.

alex-courtis avatar Feb 16 '25 01:02 alex-courtis

@alex-courtis updated

xiantang avatar Feb 16 '25 09:02 xiantang

Proposed help, please correct indexes and run make help-update when done.

==============================================================================
 5.19 OPTS: BOOKMARKS                               *nvim-tree-opts-bookmarks*

*nvim-tree.bookmarks.persist*
Persist bookmarks to a json file containing a list of absolute paths.
Type: `boolean` | `string`, Default: `false`

`true`: use default: `stdpath("data") .. "/nvim-tree-bookmarks.json"`
`string`: absolute path of your choice.

alex-courtis avatar Feb 16 '25 23:02 alex-courtis

I've added you to this repository so that you may push branches and run CI in the future.

alex-courtis avatar Feb 22 '25 00:02 alex-courtis

Apologies, I was not clear about my request to simplify options and proposed help

Attached is a patch with those changes

gunzip simplify_options.diff.gz
git apply simplify_options.diff

simplify_options.diff.gz

alex-courtis avatar Feb 22 '25 01:02 alex-courtis

@xiantang I was looking for this feature! Could you kindly add the patched changes so we can all benefit from your implementation?

Thank you and @alex-courtis for working on this :)

bburgess19 avatar May 16 '25 14:05 bburgess19

@xiantang I was looking for this feature! Could you kindly add the patched changes so we can all benefit from your implementation?

Thank you and @alex-courtis for working on this :)

If we don't hear back from @xiantang I would be most grateful for a new PR from you @bburgess19 with all the changes.

alex-courtis avatar May 18 '25 01:05 alex-courtis

@xiantang

Would you like me to complete this and merge it?

alex-courtis avatar Jun 14 '25 07:06 alex-courtis

ok i will continue it

On Sat, 14 Jun 2025 at 3:29 PM, Alexander Courtis @.***> wrote:

alex-courtis left a comment (nvim-tree/nvim-tree.lua#3033) https://github.com/nvim-tree/nvim-tree.lua/pull/3033#issuecomment-2972423856

@xiantang https://github.com/xiantang

Would you like me to complete this and merge it?

— Reply to this email directly, view it on GitHub https://github.com/nvim-tree/nvim-tree.lua/pull/3033#issuecomment-2972423856, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIHB3TZ3Y5GOG3S2QK5HYUT3DPFNZAVCNFSM6AAAAABUBK6ZJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNZSGQZDGOBVGY . You are receiving this because you were mentioned.Message ID: @.***>

xiantang avatar Jun 14 '25 08:06 xiantang

sorry for misunderstanding, u can complete this merge request.

On Sat, 14 Jun 2025 at 3:29 PM, Alexander Courtis @.***> wrote:

alex-courtis left a comment (nvim-tree/nvim-tree.lua#3033) https://github.com/nvim-tree/nvim-tree.lua/pull/3033#issuecomment-2972423856

@xiantang https://github.com/xiantang

Would you like me to complete this and merge it?

— Reply to this email directly, view it on GitHub https://github.com/nvim-tree/nvim-tree.lua/pull/3033#issuecomment-2972423856, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIHB3TZ3Y5GOG3S2QK5HYUT3DPFNZAVCNFSM6AAAAABUBK6ZJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNZSGQZDGOBVGY . You are receiving this because you were mentioned.Message ID: @.***>

xiantang avatar Jun 14 '25 08:06 xiantang

sorry for misunderstanding, u can complete this merge request.

I would be very grateful if you completed. You deserve all the credit for this great feature.

alex-courtis avatar Jun 15 '25 04:06 alex-courtis