Syntax highlighting for TSX files
Describe the bug
The syntax highlighting for TSX isn't working properly. You can take a look at the color of the HTML tags and the content inside them, they are the same color. I'm using the same theme settings that are in the init.lua repo. However, I've also tried another theme, the Catppuccin, and I faced inconsistencies with the syntax highlighting as well.
To Reproduce Steps to reproduce the behavior:
- Follow the guide in the README
- Open a TSX file
Desktop (please complete the following information):
- OS: macOS Ventura 13.1
- Terminal: Kitty 0.26.4
** Neovim Version **
- Output of running
:versionfrom inside of neovim: NVIM v0.8.2
File example
import React from "react";
type Props = { text: string; color?: string };
function Title({ text, color }: Props) {
const style = { color: color ?? "blueviolet" };
return <h1 style={style}>{text}</h1>;
}
const Header = () => <header>Header component</header>;
export const App = () => (
<>
<Header />
<Title text="Hello World" />
<p>
lorem ipsum dolor etc lorem ipsum dolor etc lorem ipsum dolor etc lorem
ipsum dolor etc lorem ipsum dolor etc lorem ipsum dolor etc
</p>
</>
);
I had to install tsx (https://github.com/tree-sitter/tree-sitter-typescript) for tree-sitter. Since this is a popular syntax people may want to have built-in and typescript is already supported in the ensure_installed array https://github.com/nvim-lua/kickstart.nvim/blob/32744c3f66ac9e66e4ac5cc9d181db50254c44b3/init.lua#L224, I think it would be nice to have tsx there by default as well. What do you think? I'll make a PR for it :+1:
With all respect, I would argue that the ensured installed should only have the minimal defaults. Polluting that options will bloat the install and not everyone will need those configurations. But highly encourage adding documentation and notes even creating a section in the README on those tips.
Thanks, sorry for the late reply. I will add tsx by default in #178
Closed in favor of #178