nvda
nvda copied to clipboard
NVDA+F1 now opens the log viewer even when the logging is disabled
Link to issue number:
Closes #19318
Summary of the issue:
The log cannot be opened when log level is on Disabled.
Description of user facing changes:
The log can be opened when log level is on Disabled.
Description of developer facing changes:
N/A
Description of development approach:
When log is disabled, just open the log as if we had clicked the corresponding NVDA menu item.
Testing strategy:
Manual test with:
- Changing the log level in the settings dialog
- starting with
-l 100flag
Known issues with pull request:
No test performed with --no-logging flag due to #19333.
Code Review Checklist:
- [x] Documentation:
- Change log entry
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
- [x] Testing:
- Unit tests
- System (end to end) tests
- Manual testing
- [x] UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English
- [x] API is compatible with existing add-ons.
- [x] Security precautions taken.
Noticed either I in the past, thanks Cyrille to fix it!