nvda icon indicating copy to clipboard operation
nvda copied to clipboard
verified publisher icon nvaccess

Update button

Open SaschaCowley opened this issue 2 years ago • 5 comments

Link to issue number:

#15720

Summary of the issue:

When performing an update on a portable copy of NVDA, the update button uses the word "install", which may cause confusion among users.

Description of user facing changes

Updated install buttons to use "update" instead of ""install".

Description of development approach

Simple string swap.

Testing strategy:

Ran unit and translation checks.

Known issues with pull request:

None

Code Review Checklist:

  • [ ] Documentation:
    • Change log entry
    • User Documentation (pending)
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes (pending)
  • [x] Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing (pending)
  • [x] UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • [ ] API is compatible with existing add-ons. N/A
  • [ ] Security precautions taken. N/A

SaschaCowley avatar Jan 12 '24 09:01 SaschaCowley

Its not strictly an update though. Make a portable copy then start. Brian

-- @.*** Sent via blueyonder.(Virgin media) Please address personal E-mail to:- @.***, putting 'Brian Gaff' in the display name field. ----- Original Message ----- From: Sascha Cowley To: nvaccess/nvda Cc: Subscribed Sent: Friday, January 12, 2024 9:20 AM Subject: [nvaccess/nvda] Update button (PR #16034)

Link to issue number: #15720

Summary of the issue: When performing an update on a portable copy of NVDA, the update button uses the word "install", which may cause confusion among users.

Description of user facing changes Updated install buttons to use "update" instead of ""install".

Description of development approach Simple string swap.

Testing strategy: Ran unit and translation checks.

Known issues with pull request: None

Code Review Checklist: a.. Documentation: a.. Change log entry b.. User Documentation (pending) c.. Developer / Technical Documentation d.. Context sensitive help for GUI changes (pending) b.. Testing: a.. Unit tests b.. System (end to end) tests c.. Manual testing (pending) c.. UX of all users considered: a.. Speech b.. Braille c.. Low Vision d.. Different web browsers e.. Localization in other languages / culture than English d.. API is compatible with existing add-ons. N/A e.. Security precautions taken. N/A

You can view, comment on, or merge this pull request online at: https://github.com/nvaccess/nvda/pull/16034

Commit Summary a.. a581aec Updated install buttons not to use word 'update' b.. 545ceca Added changelog entry File Changes (2 files) a.. M source/updateCheck.py (4) b.. M user_docs/en/changes.t2t (1) Patch Links: a.. https://github.com/nvaccess/nvda/pull/16034.patch b.. https://github.com/nvaccess/nvda/pull/16034.diff — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Brian1Gaff avatar Jan 12 '24 09:01 Brian1Gaff

  • PASS: Translation comments check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • FAIL: System tests (tags: installer NVDA). See test results for more information.
  • Build (for testing PR): https://ci.appveyor.com/api/buildjobs/e8ipmv9ljhny7qk1/artifacts/output/nvda_snapshot_pr16034-30631,2b59149d.exe
  • CI timing (mins): INIT 0.0, INSTALL_START 0.9, INSTALL_END 1.0, BUILD_START 0.0, BUILD_END 28.3, TESTSETUP_START 0.0, TESTSETUP_END 0.3, TEST_START 0.0, TEST_END 16.6, FINISH_END 0.1

See test results for failed build of commit 2b59149d5b

AppVeyorBot avatar Jan 12 '24 10:01 AppVeyorBot

  • PASS: Translation comments check.
  • PASS: Unit tests.
  • PASS: Lint check.
  • FAIL: System tests (tags: installer NVDA). See test results for more information.
  • Build (for testing PR): https://ci.appveyor.com/api/buildjobs/op3i8p74d14sd8em/artifacts/output/nvda_snapshot_pr16034-30897,714ecdce.exe
  • CI timing (mins): INIT 0.0, INSTALL_START 1.0, INSTALL_END 1.0, BUILD_START 0.0, BUILD_END 27.9, TESTSETUP_START 0.0, TESTSETUP_END 0.4, TEST_START 0.0, TEST_END 10.6, FINISH_END 0.1

See test results for failed build of commit 714ecdce8b

AppVeyorBot avatar Jan 31 '24 02:01 AppVeyorBot

  • FAIL: Translation comments check. Translation comments missing or unexpectedly included. See build log for more information.
  • PASS: Unit tests.
  • PASS: Lint check.
  • PASS: System tests (tags: installer NVDA).
  • Build (for testing PR): https://ci.appveyor.com/api/buildjobs/kkgmc6tqfwaaynwx/artifacts/output/nvda_snapshot_pr16034-30968,639261e4.exe
  • CI timing (mins): INIT 0.0, INSTALL_START 1.0, INSTALL_END 0.9, BUILD_START 0.0, BUILD_END 28.4, TESTSETUP_START 0.0, TESTSETUP_END 0.3, TEST_START 0.0, TEST_END 2.2, FINISH_END 0.1

See test results for failed build of commit 639261e4be

AppVeyorBot avatar Feb 07 '24 00:02 AppVeyorBot

Could you also update the PR description "link to issue number" to be phrased as "Fixes #15720"

seanbudd avatar Feb 21 '24 22:02 seanbudd

  • PASS: Translation comments check.
  • PASS: Unit tests.
  • FAIL: Lint check. See test results for more information.
  • PASS: System tests (tags: installer NVDA).
  • Build (for testing PR): https://ci.appveyor.com/api/buildjobs/9jff5ljf2ar6n014/artifacts/output/nvda_snapshot_pr16034-31231,b529fdbd.exe
  • CI timing (mins): INIT 0.0, INSTALL_START 1.0, INSTALL_END 0.9, BUILD_START 0.0, BUILD_END 27.8, TESTSETUP_START 0.0, TESTSETUP_END 0.4, TEST_START 0.0, TEST_END 2.2, FINISH_END 0.5

See test results for failed build of commit b529fdbdab

AppVeyorBot avatar Feb 28 '24 05:02 AppVeyorBot