addon-datastore icon indicating copy to clipboard operation
addon-datastore copied to clipboard

Change the bot name for reviews to something more friendly

Open XLTechie opened this issue 1 year ago • 2 comments

Currently, the name of the bot used for add-on review discussions is:

github-actions[bot]

While this name is standard throughout the add-on management process, I do not think it is the most friendly for end users, who are supposed to use and contribute to the reviews.

Therefore I would like to suggest that this name be changed for future review discussions, to something more like:

NV Access Review Bot

Or even:

NVDA Add-on Review Management

I looked at nvdaes/build-discussion, but it doesn't appear to be set there. I think it is either coming from the committer, or from the setting in checkAndSubmitAddonMetadata.yml. I am not confident of everything going on in the review job there, so I didn't submit a pull request.

XLTechie avatar Feb 29 '24 09:02 XLTechie

I didn't specify GitHub Actions bot name in nvdaes/build-discussion, and I don't know if this name can be changed if GitHub Actions are used.

nvdaes avatar Feb 29 '24 09:02 nvdaes

From looking in the YAML earlier, it's set for both the "Author:" field in a few places, and as the git commit name in gitconfig. Not sure if those matter, if GitHub would just override them with what it wants, or not.

It may be possible for commit listings by changing the listed email address, but not sure of discussions. https://stackoverflow.com/questions/76330731/change-display-name-for-github-actions-bot-commit

Perhaps I will play with this in a test repo next week.

XLTechie avatar Feb 29 '24 11:02 XLTechie