ui icon indicating copy to clipboard operation
ui copied to clipboard

docs(page-hero): add `externalTypes` to component code with links

Open Yizack opened this issue 3 months ago โ€ข 2 comments

โ“ Type of change

  • [x] ๐Ÿ“– Documentation (updates to the documentation or readme)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [ ] ๐Ÿ‘Œ Enhancement (improving an existing functionality)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Hello, this PR helps to make it clear that we know the links constant should be an array of ButtonProps

Added the types to sections where code includes external links (Links, Orientation, Reverse)

๐Ÿ“ Checklist

  • [ ] I have linked an issue or discussion.
  • [x] I have updated the documentation accordingly.

Yizack avatar Nov 06 '25 22:11 Yizack

npm i https://pkg.pr.new/@nuxt/ui@5397

commit: ea0dab5

pkg-pr-new[bot] avatar Nov 06 '25 22:11 pkg-pr-new[bot]

We could change this indeed but only if it's done in every component for consistency.

Hello! I thought of doing that too, if you want I can work on checking all components for missing externalTypes, ask you for review when done and rename this PR with a components scope

Yizack avatar Nov 07 '25 09:11 Yizack