ui
ui copied to clipboard
docs(page-hero): add `externalTypes` to component code with links
โ Type of change
- [x] ๐ Documentation (updates to the documentation or readme)
- [ ] ๐ Bug fix (a non-breaking change that fixes an issue)
- [ ] ๐ Enhancement (improving an existing functionality)
- [ ] โจ New feature (a non-breaking change that adds functionality)
- [ ] ๐งน Chore (updates to the build process or auxiliary tools and libraries)
- [ ] โ ๏ธ Breaking change (fix or feature that would cause existing functionality to change)
๐ Description
Hello, this PR helps to make it clear that we know the links constant should be an array of ButtonProps
Added the types to sections where code includes external links (Links, Orientation, Reverse)
๐ Checklist
- [ ] I have linked an issue or discussion.
- [x] I have updated the documentation accordingly.
We could change this indeed but only if it's done in every component for consistency.
Hello! I thought of doing that too, if you want I can work on checking all components for missing externalTypes, ask you for review when done and rename this PR with a components scope