rfcs icon indicating copy to clipboard operation
rfcs copied to clipboard

Discuss if Modern building for assets(CSS..) is necessary

Open clarkdo opened this issue 7 years ago • 6 comments

Discussion Points:

  • [ ] Do we need to build different assets (modern and legacy) like: css with different browsers postcss preset ?
  • [ ] How to serve the assets in SSR and SPA ?
  • [ ] bundles separation
  • [ ] TBD

clarkdo avatar Nov 09 '18 12:11 clarkdo

What about having modern CSS for the modern build when not having extractCSS?

atinux avatar Nov 20 '18 19:11 atinux

@Atinux Like that idea! Not much overhead to the current situation and somewhat straightforward implementation I think

TheAlexLichter avatar Nov 20 '18 19:11 TheAlexLichter

@Atinux CSS is different from js files, it's only related to postcss, so do you agree that we use current modern browser list to config postcss-preset-env?

And also do you think it's necessary that also build legacy css files with default postcss preset in modern mode ?

clarkdo avatar Nov 20 '18 20:11 clarkdo

I am talking about the CSS when injected through the JS bundle (when no extractCSS). So yes, when modern mode, we should also set postcss-preset-env to modern browsers.

With extractCSS, I don't know if we can have 2 different CSS file for SPA & Generated.

atinux avatar Nov 20 '18 22:11 atinux

@Atinux but what complexity does extractCSS adds to the implementation? I use extractCSS (when it's working) a lot and this feature would really feel half implemented if it will cause such limitations

AndrewBogdanovTSS avatar Feb 14 '19 16:02 AndrewBogdanovTSS

Well I guess it could support also extractCSS I believe since it's two different build. The main question is: Is it possible to detect the "modern" css files vs "legacy" one?

atinux avatar Mar 20 '19 16:03 atinux