fonts icon indicating copy to clipboard operation
fonts copied to clipboard

feat: add option to toggle `addLocalFallbacks`

Open qwerzl opened this issue 1 year ago โ€ข 1 comments

๐Ÿ”— Linked issue

Resolves #211.

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation or readme)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [x] ๐Ÿ‘Œ Enhancement (improving an existing functionality)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

@danielroe

Quick fix. This PR passes down the addLocalFallbacks option to the function so that it decides whether to add the fallbacks or not.

qwerzl avatar Aug 15 '24 17:08 qwerzl

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.82%. Comparing base (f4cf7e8) to head (85b11a6). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/module.ts 93.75% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   40.61%   40.82%   +0.20%     
==========================================
  Files          59       59              
  Lines        3560     3569       +9     
  Branches      437      437              
==========================================
+ Hits         1446     1457      +11     
+ Misses       2075     2073       -2     
  Partials       39       39              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Aug 15 '24 17:08 codecov-commenter