fonts icon indicating copy to clipboard operation
fonts copied to clipboard

feat: googleicons provider

Open qwerzl opened this issue 1 year ago • 6 comments

This PR resolves #127, adds a new googleicons provider. One thing that's weird is that Google seems to return an invalid JSON in their https://fonts.google.com/metadata/icons endpoints (There are random characters on the first line). So the first line is ignored.

qwerzl avatar Apr 22 '24 03:04 qwerzl

Codecov Report

Attention: Patch coverage is 57.60000% with 53 lines in your changes missing coverage. Please review.

Project coverage is 40.61%. Comparing base (ef74666) to head (c503a8d). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
playground/pages/providers/googleicons.vue 0.00% 45 Missing and 1 partial :warning:
src/providers/googleicons.ts 90.90% 7 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   40.00%   40.61%   +0.61%     
==========================================
  Files          57       59       +2     
  Lines        3435     3560     +125     
  Branches      433      437       +4     
==========================================
+ Hits         1374     1446      +72     
- Misses       2023     2075      +52     
- Partials       38       39       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 22 '24 03:04 codecov-commenter

@qwerzl That was quick! Would it be possible to also specificy custom values for the font variations. Currently it's set to opsz,wght,FILL,[email protected],100..700,0..1,-50..200 but with the possibility to add our own values here we can substantially reduce the size of the file that is being requested. As an example this is our current font variations allowing for the smallest file size possible: :opsz,FILL@20,0..1

AndersCV avatar Apr 22 '24 07:04 AndersCV

@AndersCV Would there be a way to detect what you need without configuration, do you think? What does your usage look like?

danielroe avatar Apr 22 '24 07:04 danielroe

@danielroe

Currently we're using the "@nuxtjs/google-fonts": "3.0.2", module to request our font files with this config in our nuxt.config.ts

googleFonts: {
    display: 'swap',
    families: {
      'Material Symbols Rounded:opsz,FILL@20,0..1': true,
    },
  },

In our case we have a simple <Icon> component that accepts only one prop which is "fill: 0 | 1" because our design makes use of icons with both fill: 0 and fill: 1.

This is purposely done so we can request a font file that is as small in file size as possible, otherwise the whole material symbols font file can be several MBs which is not great. Ideally we would like to reduce the file size further by somehow only including the nessecary icons, but I think thats beyond my expertise. I think our current file size comes down to 440~kb.

Detecting this without some form of configuration I don't think is possible as the font-family is applied inside our custom component.

AndersCV avatar Apr 22 '24 08:04 AndersCV

I guess the first thing we should do is to support setting variable weight ranges. Currently every variable font is defaulted to maximum weight ranges for every provider.

qwerzl avatar Apr 23 '24 07:04 qwerzl

Sorry for the accidentally closing this PR! Reopening it.

qwerzl avatar May 30 '24 13:05 qwerzl