i18n icon indicating copy to clipboard operation
i18n copied to clipboard

feat: add httpOnly flag to cookie options in getI18nCookie function

Open hoythan opened this issue 1 year ago β€’ 2 comments

πŸ”— Linked issue

https://github.com/nuxt-modules/i18n/issues/3059

❓ Type of change

  • [ ] πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • [ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [ ] πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • [x] ✨ New feature (a non-breaking change that adds functionality)
  • [ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #3059

πŸ“ Checklist

  • [ ] I have linked an issue or discussion.
  • [ ] I have added tests (if possible).
  • [ ] I have updated the documentation accordingly.

hoythan avatar Aug 13 '24 17:08 hoythan

Wouldn't setting httpOnly: true break language switching since the cookie cannot be changed on the client-side? If that is the case, we should add this to the documentation πŸ€”

BobbieGoede avatar Aug 14 '24 07:08 BobbieGoede

Wouldn't setting httpOnly: true break language switching since the cookie cannot be changed on the client-side? If that is the case, we should add this to the documentation πŸ€”

It’s possible to encounter this issue. While the cookie may not update immediately when the user switches the language using useSwitchLocalePath, it will sync with the address upon refreshing the current page.

hoythan avatar Aug 16 '24 07:08 hoythan