html-validator icon indicating copy to clipboard operation
html-validator copied to clipboard

feat: add compatibility with nitro (nuxt 3 + nuxt bridge)

Open danielroe opened this issue 3 years ago • 1 comments

danielroe avatar Aug 19 '22 18:08 danielroe

I get the following error message trying this branch on bridge:

 FATAL  Cannot find module '/..../node_modules/@nuxtjs/html-validator/dist/runtime/validator' imported from /..../node_modules/@nuxtjs/html-validator/dist/module.mjs

  at new NodeError (node:internal/errors:387:5)
  at finalizeResolution (node:internal/modules/esm/resolve:404:11)
  at moduleResolve (node:internal/modules/esm/resolve:965:10)
  at defaultResolve (node:internal/modules/esm/resolve:1173:11)
  at nextResolve (node:internal/modules/esm/loader:173:28)
  at ESMLoader.resolve (node:internal/modules/esm/loader:852:30)
  at ESMLoader.getModuleJob (node:internal/modules/esm/loader:439:18)
  at ESMLoader.import (node:internal/modules/esm/loader:536:22)
  at importModuleDynamically (node:internal/modules/esm/translators:110:35)
  at importModuleDynamicallyCallback (node:internal/process/esm_loader:35:14)

I have a validator.mjs in the mentioned runtime directory though.

dargmuesli avatar Aug 27 '22 01:08 dargmuesli

Hey @danielroeand @dargmuesli, will this PR support the failOnError option for Nuxt Bridge and Nuxt 3? Thanks!

yoonpoon avatar Sep 15 '22 17:09 yoonpoon

It does 😊

I only need to make a couple of tweaks and it's ready to go

danielroe avatar Sep 15 '22 17:09 danielroe

Deploy Preview for html-validator canceled.

Name Link
Latest commit c8bb858685aa69cb2919a5445d0bb1aa410f3d22
Latest deploy log https://app.netlify.com/sites/html-validator/deploys/633054bebcbbec0008e4f779

netlify[bot] avatar Sep 18 '22 20:09 netlify[bot]