google-fonts icon indicating copy to clipboard operation
google-fonts copied to clipboard

What does v3 "breaking change" mean?

Open bmulholland opened this issue 3 years ago • 6 comments

v3 has "support for nuxt 3" listed as a "breaking change," but there's no indication of what breaks or how to fix it. Is it actually a breaking change? For what? What action is needed to upgrade?

bmulholland avatar Jul 26 '22 11:07 bmulholland

there's no indication of what breaks

Well, the Nuxt 2 support I think.

Skyost avatar Jul 28 '22 18:07 Skyost

The PR in question has explicit handling for Nuxt 2: https://github.com/nuxt-community/google-fonts-module/pull/94/files#diff-030fc083b2cbf5cf008cfc0c49bb4f1b8d97ac07f93a291d068d81b4d1416f70R51

bmulholland avatar Jul 28 '22 18:07 bmulholland

If you're not using nuxt v3, please install "@nuxtjs/google-fonts": "^2.0.0"

josueayala27 avatar Aug 03 '22 18:08 josueayala27

@josuemartinezz Can you please give more details? I see that you aren't a contributor/maintainer: how do you know that is important? Why is it important? If that restriction is indeed in place, then it should be very clearly called out in the README, release notes, and so on.

bmulholland avatar Aug 04 '22 09:08 bmulholland

@bmulholland Nuxt v3 is a complete rewrite of v2, therefore the underlying technologies are different and require different methods to get things to work. You can research how to migrate from v2 to v3 or lookup the general differences, but this repo is not really the place to list all those out.

TLDR; no Nuxt v2 module work with Nuxt v3, they have to be rewritten. See more details in this PR.

joserocha3 avatar Aug 22 '22 13:08 joserocha3

@joserocha3 I'm well aware of the difference between v2 and v3.

@nuxt/kit, which the PR you linked to uses, explicitly supports | Nuxt 2. The Nuxt Tailwind module, for instance, uses nuxt/kit to support both Nuxt 2 and Nuxt 3. In fact, I've used the latest version of the google fonts module in production with both Nuxt 2 and Nuxt Bridge, so unless I'm missing something, I'm pretty confident Nuxt 2 is still supported.

I'm trying to give you the benefit of the doubt here, which is why I asked how you knew this. Do you have insider knowledge that Nuxt 2 support indeed doesn't work? Perhaps you know there's feature(s) that I don't use that are actually broken? Or perhaps my setup is only working accidentally, and you know it shouldn't actually work? Knowing the answers to these questions would require detailed knowledge of the pieces involved, and if so, it's important that I know!

However, given that you only answered in general comments about Nuxt v2/v3, it seems that you may not be as well informed as you represent when making blanket statements about supported veresions. I'm calling this out because, unless I'm missing something (as above), your comment appears to be misleading people.

bmulholland avatar Aug 22 '22 13:08 bmulholland

If you're not using nuxt v3, please install "@nuxtjs/google-fonts": "^2.0.0"

thanks josueayala27, this should be on the documentation when installing the plugin. I spent some hours looking at the issue, until I found your comment.

jillesca avatar Oct 08 '22 13:10 jillesca

Hi @bmulholland The v3 version of this module should work with nuxt 2 and 3

The main reason it is a "break change" is that its default settings have different values v2 -https://github.com/nuxt-community/google-fonts-module/blob/v2.0.0/src/module.ts#L22-L39 v3 - https://github.com/nuxt-community/google-fonts-module/blob/main/src/module.ts#L23-L40

Not to mention the module has been completely rewritten Theoretically no additional configuration is needed to migrate to v3

ricardogobbosouza avatar Oct 19 '22 16:10 ricardogobbosouza